Skip to content

Made SNMP privacy protocol selectable#41

Merged
wernerfred merged 5 commits intowernerfred:masterfrom
dommi22m:patch-2
Jan 8, 2024
Merged

Made SNMP privacy protocol selectable#41
wernerfred merged 5 commits intowernerfred:masterfrom
dommi22m:patch-2

Conversation

@dommi22m
Copy link
Copy Markdown
Contributor

@dommi22m dommi22m commented Aug 15, 2022

This is my version to make the privacy protocol selectable. AES128 is used as default.

wernerfred
wernerfred requested changes Aug 15, 2022
View reviewed changes
Copy link
Copy Markdown
Owner

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Please add the new option [-s [AES128|DES]] to the usage in the README.md accordingly.

Why specifically did you choose -s? Maybe we should change this to -e(encryption?) to save -s for future usecases that are more related to the letter s? What's your opinion on that?

@dommi22m
Copy link
Copy Markdown
Contributor Author

dommi22m commented Aug 16, 2022 •
edited
Loading

Please add the new option [-s [AES128|DES]] to the usage in the README.md accordingly.

Done!

Why specifically did you choose -s? Maybe we should change this to -e(encryption?) to save -s for future usecases that are more related to the letter s? What's your opinion on that?

Yes you are right! I was thinking in the direction of "secret". But that would not be logical and also wrong in terms of content.

wernerfred
wernerfred requested changes Aug 16, 2022
View reviewed changes
Copy link
Copy Markdown
Owner

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small whitespace fix, rest LGTM 👍🏻

@wernerfred
Copy link
Copy Markdown
Owner

wernerfred commented Aug 16, 2022

@all-contributors add @dommi22m for code

@allcontributors allcontributors bot mentioned this pull request Aug 16, 2022
Open
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors bot commented Aug 16, 2022

@wernerfred

I've put up a pull request to add @dommi22m! 🎉

@amotl amotl mentioned this pull request Oct 13, 2022
Open
@wernerfred wernerfred merged commit 5aa3221 into wernerfred:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wernerfred wernerfred wernerfred approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dommi22m @wernerfred